Conversation
When we I mistook `lambda.json` format (ex. like miswrite ,), it tell us what file was mistook.
Contributor
|
Currently if I have an invalid JSON file the error message comes back "ValueError: Expecting , delimiter: line 4 column 3 (char 50)" which provides me a reason why the JSON file is not valid. Your proposed PR only tells us that the configuration file is invalid, not why. I would prefer the error message be more informative than "x" file is bad. Can you rewrite the error to include the original error message as well as what file is incorrect. Also after testing on my local setup, your PR doesn't appear to work for Python 2.7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we I mistook
lambda.jsonformat (ex. like miswrite ,), it tell us what file was mistook.